Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added taar_update_whitelist to the taar_amodump DAG #405

Merged
merged 4 commits into from
May 9, 2019

Conversation

crankycoder
Copy link
Contributor

Adds a job to extract the AMO editorial content and generate a JSON blob with all editorial reviewed GUIDs in an S3 bucket.

@crankycoder
Copy link
Contributor Author

@acmiyaguchi This has been in queue for ages - can we get this reviewed?

Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been sitting in the queue forever -- sorry about that. For what it's worth, this looks good to me

email=["mlopatka@mozilla.com", "vng@mozilla.com"],
env=mozetl_envvar("taar_update_whitelist",
{},
{'MOZETL_SUBMISSION_METHOD': 'spark'}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOZETL_SUBMISSION_METHOD should be set to spark by default, and will be ignored by MozDatabricksRunSubmit if it's every moved over.

Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this is missing a required option.

dags/taar_amodump.py Outdated Show resolved Hide resolved
@acmiyaguchi acmiyaguchi merged commit cc66651 into mozilla:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants