Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard links should point to an HTML file #667

Closed
mikaeld opened this issue Oct 27, 2022 · 1 comment
Closed

Dashboard links should point to an HTML file #667

mikaeld opened this issue Oct 27, 2022 · 1 comment
Labels

Comments

@mikaeld
Copy link

mikaeld commented Oct 27, 2022

Description

The Data SRE team recently migrated this project's infrastructure from AWS to GCP. While assessing our migration, we've noticed some links pointing to a directory rather than an HTML file (see examples below).

I can't recall if the links were working before the migration. It is possible that AWS CloudFront automatically rewrote URLs to index.html and that the GCP equivalent does not. Edit: The previous setup was relying on an AWS feature called S3 website endpoint. Using that endpoint URL returns the default index document that you configure for the website. However Amazon S3 website endpoints do not support HTTPS or access points, which is why we can't use it with this GCP migration.

We could handle this by manually specifying path matching rules to enforce url rewrites, however this would mean an infrastructure re-deployment every time a new link is added. This is not an ideal fix for the issue

It would be preferable to simply change the links in this project. Links like Measurement Dashboard and Dashboard Generator already point to their HTML files.

Examples

Thanks!

@mikaeld mikaeld added the bug label Oct 27, 2022
chutten added a commit to chutten/telemetry-dashboard that referenced this issue Oct 27, 2022
@chutten
Copy link
Contributor

chutten commented Oct 27, 2022

Fixed by #668

@chutten chutten closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants