Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some cookies not being removed when uninstalling containers #522

Closed
kjozwiak opened this issue May 19, 2017 · 4 comments
Closed

some cookies not being removed when uninstalling containers #522

kjozwiak opened this issue May 19, 2017 · 4 comments
Labels
bug Something is broken! Needs: Mozilla Central Needs changes in Mozilla-Central Needs: Testing Needs more investigation

Comments

@kjozwiak
Copy link

I'm not sure how many cookies this affects, but there's times where a few cookies are left behind with an associated userContextId even though the containers experiment has been removed. I've ran into this a few times and finally found a 100% reproducible case. In this example, there's two cookies that are left behind that belong to adnxs.com which looks like it's an online auction exchange used to sell advertising space.

This affects all versions so it's not a blocker for the 2.3.0 release.

STR (example: https://youtu.be/Msz3tddoIC0):

  • install fx and any version of containers (I used 2.3.0 but reproduced with other versions)
  • once installed, open a container (in my example, I used banking)
  • login into draftkings.com (should be free to create an account)
  • once logged in, go back into the test pilot containers page and remove containers

If you look under about:preferences#privacy and cookies.sqlite, you'll see the two following cookies which should have been removed as well:

screen shot 2017-05-19 at 4 16 53 pm

I've added a video for an example which shows me logging in and removing the experiment. You'll notice when I check about:preferences#privacy and cookies.sqlite, two cookies are left behind that are still associated with userContextId=3.

I'm going to check to see if this is reproducible with the m-c implementation of Containers and create the appropriate bug if it's reproducible.

@kjozwiak kjozwiak added the bug Something is broken! label May 19, 2017
@jonathanKingston
Copy link
Contributor

This makes me think this is a race condition in clearing the cookies here. @bakulf do you know if we clear these if the preference gets changes in m-c?

@kjozwiak
Copy link
Author

I've managed to run into this again with a cookie from Ebay. Once I removed all the containers via the "Containers" button, I checked the cookies.sqlite database and noticed the following cookie being left behind:

screen shot 2017-05-24 at 2 42 38 pm

This makes me think this is a race condition in clearing the cookies here.

I think @jonathanKingston is right... We probably have a race condition when clearing cookies. This usually happens when I start deleting several Containers at the same time. There's always a cookie or two left that will only get cleared when you clear everything from FX. Removing the Containers experiment doesn't remove the cookie either.

@jonathanKingston jonathanKingston added the Needs: Mozilla Central Needs changes in Mozilla-Central label May 26, 2017
@kjozwiak
Copy link
Author

I've managed to reprduce this on m-c using the platform implementaion of containers and created Bug#1368815

@groovecoder groovecoder added Needs: Testing Needs more investigation P1 bug labels Dec 5, 2017
@groovecoder
Copy link
Member

I can't reproduce this anymore, and we have a couple of platform-level bugs for it. Closing the add-on bug here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Needs: Mozilla Central Needs changes in Mozilla-Central Needs: Testing Needs more investigation
Projects
None yet
Development

No branches or pull requests

3 participants