Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab closing became very slow in today's nightly #598

Closed
past opened this issue Jun 16, 2017 · 6 comments
Closed

Tab closing became very slow in today's nightly #598

past opened this issue Jun 16, 2017 · 6 comments
Labels
bug Something is broken!

Comments

@past
Copy link

past commented Jun 16, 2017

I've been using containers for quite some time, but I noticed after today's update that my nightly was very slow to close a tab when containers was enabled. This happened on my main profile in both windows and macOS.

Here is a profile: https://perfht.ml/2rzd7Pf

mconley and florian suggested that sending telemetry is what is causing this. sendTelemetryPayload from resource://testpilot-containers/index.js may be triggering bug 1369594.

Could be related to mozilla/testpilot#2422.

@mikeconley
Copy link

Filed by a separate user here: https://bugzilla.mozilla.org/show_bug.cgi?id=1373822

@jonathanKingston
Copy link
Contributor

Hey @groovecoder the sendTelemetryPayload method goes straight to sending the call right? I wonder if using a message queue style setup to send the events on shutdown and when the browser is idle?

Should shared workers be investigated for preventing telemetry blocking the main code?

@kjozwiak
Copy link

Here's another profile that was added in bug#1373822 which demonstrates the performance regression.

@grahamperrin
Copy link

Please: with release 56.0 of Firefox, is this still an issue?

If it helps: Mozilla bug 1373822 - Lag when closing tabs is RESOLVED INVALID.

@past
Copy link
Author

past commented Oct 4, 2017

Well that bug was closed as invalid, because this issue was the place where we would track the problem. That being said, I haven't experienced this issue again in the last few months.

@groovecoder
Copy link
Member

Closing unless/until we can reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken!
Projects
None yet
Development

No branches or pull requests

6 participants