Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save to Pocket toolbar button doesn't work when getpocket.com is containerized #824

Open
kefkf opened this issue Sep 16, 2017 · 5 comments
Labels
bug Something is broken! Needs: Mozilla Central Needs changes in Mozilla-Central Status: Addon Compatibility Issues related to compatibility issues with other addons

Comments

@kefkf
Copy link

kefkf commented Sep 16, 2017

The Save to Pocket toolbar button shows the login popup even though getpocket.com is logged in in a containerized tab.

Steps to reproduce:

  • Log out of pocket
  • Add getpocket.com to a container, make sure Always Open in This Container is selected
  • Try to add a site to pocket via the Save to Pocket toolbar button.
  • The login dialog pops up on the toolbar, click Log in
  • Login to pocket in a new containerized tab
  • Go back to the tab you had wanted to save to pocket
  • Click the Save to Pocket button, the same login dialog pops up even though you are logged in to pocket in a containerized tab

I'm using Firefox 55.0.3 64bit on Linux with Gnome 3.24.2.

about:support: https://imgur.com/a/fOLBO

┆Issue is synchronized with this Jira Task

@kefkf kefkf changed the title Save to Pocket button doesn't work when getpocket.com is containerized Save to Pocket toolbar button doesn't work when getpocket.com is containerized Sep 16, 2017
@groovecoder groovecoder added the bug Something is broken! label Sep 16, 2017
@jonathanKingston
Copy link
Contributor

This will be the same of Firefox accounts also, the only way to solve bugs like this are:

  • Treat URLs that are part of the browser UI as privledged and not able to be assigned ever
  • Work with these native UI pieces to work with containers, this likey would be a different solution for each part.

@TanviHacks
Copy link

If you assign pocket to a container, this is going to be an issue.

What will be the problem with Firefox accounts?

@jonathanKingston jonathanKingston added the Status: Addon Compatibility Issues related to compatibility issues with other addons label Sep 28, 2017
@stoically
Copy link
Member

Would it be feasible to exclude getpocket.com from being assigned (like about: pages)?

@tigerjack
Copy link

Just a question: if 'getpocket' is not containerized to work around this issue, does it mean that pocket cookies are saved in each container? Wouldn't it defeat the main purpose of containers?

@kendallcorner kendallcorner added the Needs: Mozilla Central Needs changes in Mozilla-Central label Dec 4, 2019
@gizmecano
Copy link

I'm not quite sure if the issues are related, but for all intents and purposes, I'm mentioning two issues currently opened in the Pocket bugtracker that may relate to this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Needs: Mozilla Central Needs changes in Mozilla-Central Status: Addon Compatibility Issues related to compatibility issues with other addons
Projects
None yet
Development

No branches or pull requests

8 participants