Conversation
difference between v7 and v6: https://github.com/isaacs/node-glob/blob/master/changelog.md#70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference between glob 6 and 7 kicks in when options.cwd is used, where it will throw an error if the "cwd" argument is not a directory. As it so happens, we use options.cwd in https://github.com/mozilla/thimble.mozilla.org/blob/fa3dde088dc016a562520e62a9df1f5558ba8f70/server/lib/utils.js so we want to make sure we have an error handler there now.
Nice catch @Pomax. @badrmodoukh can you do a fix for this in this PR? |
@badrmodoukh if you need to commit something, and don't want to add more commits, use |
server/lib/utils.js
Outdated
nodir: true | ||
}).map(file => path.join(root, file)); | ||
} | ||
catch (err) { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never, ever, ever. Not ever. Never. Not even once.
This pattern will cause you endless amounts of grief, when you have some bug where it silently fails and you don't know why. Always do something with the error.
@humphd sorry about that |
this is good to go, thanks @badrmodoukh |
I have updated the glob dependency
I tested using "npm install" and all seems to work fine from my end
I also ran "vagrant up" and loaded thimble and all worked fine