Skip to content
This repository has been archived by the owner on Jul 31, 2019. It is now read-only.

Fix #1908: Issue 1908 jquery update #1942

Merged
merged 1 commit into from Apr 13, 2017

Conversation

badrmodoukh
Copy link
Contributor

I have updated the jquery dependency
I tested using "npm install" and all seems to work fine from my end
I also ran "vagrant up" and loaded thimble and all worked fine

@Pomax
Copy link
Contributor

Pomax commented Apr 4, 2017

This is a big update, and we need to basically check to make sure that things mentioned in http://developer.telerik.com/featured/whats-new-in-jquery-3/ won't affect us during all common Thimble tasks.

@Pomax Pomax requested review from Pomax, flukeout and humphd April 4, 2017 01:26
@humphd
Copy link
Contributor

humphd commented Apr 5, 2017

I feel somewhat ill-equipped to test this, as I haven't really followed jquery in a long time. I do note that there is this: https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin @badrmodoukh, do you want to try running with that plugin to see what it reports? I don't think we use a lot of deep corners of jquery, but we do use it heavily.

It might be good to try doing everything from loading the app to starting something new, to publishing, to remixing, etc. Lots of corner cases to try.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally, I can't see any issues.

@humphd humphd merged commit a6bbd47 into mozilla:master Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants