This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
cross-wm-tool cookie management #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| navigator.id.request(); | ||
| } else { | ||
| navigator.id.logout(); | ||
| $('.publish-button.wm-button.wm-button-blue.short').hide(); |
There was a problem hiding this comment.
Surely using an ID on that element is a better idea than that selector?
There was a problem hiding this comment.
nyet; no guarantees that there is only ever one publish button, so I'm staying well away from possibly colliding identifiers.
There was a problem hiding this comment.
In which case why can't we just go with .publish-button?
There was a problem hiding this comment.
hah, completely missed that. Yes, very much so.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
surgically injected all the working bits on top of master.