Lazily setup evaluation worker #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvehent
reviewed
Jan 20, 2017
| // Try to continue with the locally hosted TLS configurations | ||
| err = json.Unmarshal([]byte(ServerSideTLSConfiguration), &sstls) | ||
| if err != nil { | ||
| log.Error(err) | ||
| log.Error("Could not load Server Side TLS configuration. Evaluation Worker not available") | ||
| //if we reach this stage, no TLS configs are loaded, so there is no need to have this worker available. | ||
| worker.RemoveWorker(workerName) |
There was a problem hiding this comment.
I think we should just panic here. I can't think of a situation where I'd want to scanner to continue when loading the local conf has failed.
There was a problem hiding this comment.
I don't think this is a valid scenario either, since fallback configurations are embedded in the code.
I will keep the RemoveWorker function in the worker just for consistency.
0xdiba
force-pushed
the
lazily_setup_eval_worker
branch
from
37d0ba0
to
2e8fc09
Compare
jvehent
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion for #193 .