Skip to content
This repository has been archived by the owner on Mar 21, 2018. It is now read-only.

dragging and dropping tabs isn't working #284

Closed
bgrins opened this issue Apr 27, 2016 · 2 comments
Closed

dragging and dropping tabs isn't working #284

bgrins opened this issue Apr 27, 2016 · 2 comments

Comments

@bgrins
Copy link
Member

bgrins commented Apr 27, 2016

Open a couple tabs, then try to drag one to the left or right and I see:

tab.jsx:63 Uncaught TypeError: this.props.onDragStart is not a function

Screenshot:
screenshot 2016-04-27 13 06 16

@jsantell
Copy link
Contributor

This was mostly disabled a few weeks ago with some refactor, I wanted to keep it but linting made not using it needlessly frustrating. No idea if worth to keep as we don't know if we'll have tabs, or just remove it.

@victorporof
Copy link
Contributor

I vote removing it

jsantell added a commit to jsantell/tofino that referenced this issue Apr 29, 2016
…ant this, and it's broken currently anyway. Fixes mozilla#284. r=bgrins
jsantell added a commit that referenced this issue Apr 30, 2016
…ant this, and it's broken currently anyway. Fixes #284. r=bgrins (#316)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants