This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Need a ratings half-star glyph #864
Assignees
Labels
Comments
|
Can't we just use a css mask or clip the asset we already have? |
|
I imagined still having the outline of the star, which not sure we can do with CSS |
|
You're right. |
|
All the stars! |
|
@phlsa thanks phil! So I was using the bookmarks star before (blue), and these are yellow, but then we're missing an empty (outline) star -- should we not show empty stars in this case, and just have the two yellow variants of full and half? |
|
My bad, sorry. I simply forgot to upload the empty star. |
jsantell
added a commit
to jsantell/tofino
that referenced
this issue
Aug 2, 2016
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the PR #863, I used the bookmark glyphs (but blue) for full and empty stars for ratings -- we need a half star for half ratings, currently stored in
app/ui/shared/assets/glyph-ratings-half-16.svg(right now it's just a copy of the hollow star).The text was updated successfully, but these errors were encountered: