Bug 1352207 - Compare view should show a tooltip on bars saying wheth…

…er the result was better or worse (#2333)
mozilla · Apr 11, 2017 · 39e5e7c · 39e5e7c
1 parent 8181a77
commit 39e5e7c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/ui/js/filters.js b/ui/js/filters.js
@@ -183,3 +183,9 @@ treeherder.filter('displayPrecision', function() {
         return parseFloat(input).toFixed(2);
     };
 });
+
+treeherder.filter('absoluteValue', function() {
+    return function(input) {
+        return Math.abs(input);
+    };
+});
diff --git a/ui/partials/perf/comparetable.html b/ui/partials/perf/comparetable.html
@@ -82,7 +82,10 @@
                     replicates="compareResult.newRuns"></ph-average>
       </td>
       <td ng-class="$ctrl.getCompareClasses(compareResult)">
-        <span ng-if="compareResult.delta" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision}}%)">
+        <span ng-if="compareResult.delta  && compareResult.newIsBetter" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision|absoluteValue}}% better)">
+          {{compareResult.deltaPercentage|displayPrecision}}%  
+        </span>
+        <span ng-if="compareResult.delta  && !compareResult.newIsBetter" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision|absoluteValue}}% worse)">
           {{compareResult.deltaPercentage|displayPrecision}}%
         </span>
       </td>