Bug 1352207 - Compare view should show a tooltip on bars saying whether the result was better or worse #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlach
reviewed
Apr 11, 2017
ui/partials/perf/comparetable.html
Outdated
| @@ -82,7 +82,10 @@ | |||
| replicates="compareResult.newRuns"></ph-average> | |||
| </td> | |||
| <td ng-class="$ctrl.getCompareClasses(compareResult)"> | |||
| <span ng-if="compareResult.delta" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision}}%)"> | |||
| <span ng-if="compareResult.delta && compareResult.newIsBetter" class="detail-hint" uib-tooltip="Mean difference: {{compareResult.delta|displayPrecision}} (= {{compareResult.deltaPercentage|displayPrecision |absoluteValue}}% better)"> | |||
There was a problem hiding this comment.
Could you remove the space between "displayPrecision and " " |absoluteValue" here and below?
i.e. displayPrecision |absoluteValue -> displayPrecision|absoluteValue
| @@ -183,3 +183,9 @@ treeherder.filter('displayPrecision', function() { | |||
| return parseFloat(input).toFixed(2); | |||
| }; | |||
| }); | |||
|
|
|||
| treeherder.filter('absoluteValue', function() { | |||
There was a problem hiding this comment.
What a pain to have to create a filter just for this. :/
(I can't find a better way though, so this is fine)
…er the result was better or worse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is