-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade common requirements: Utils #7730
Upgrade common requirements: Utils #7730
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7730 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 535 535
Lines 26329 26331 +2
Branches 3326 3326
=======================================
+ Hits 20205 20207 +2
Misses 5959 5959
Partials 165 165
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on our locally shared instance, no issue with prod dump 👌
The whitenoise update does not seem too bad all things considered.
@Archaeopteryx This is ready to be tested and reviewed whenever you are 😄 |
|
The file is listed as generated among the js bundle files in the log. There don't seem to logs which logs the individual files getting deployed. |
@Archaeopteryx Hi, I'm sorry the deployment didn't work in production, I'll take the time to look at what's wrong with this next week. In the meantime and as a preventive measure, I'm going to submit a PR that restores WhiteNoise and Redoc to their previous versions to recover an unbroken state on master. |
What is left to do:
CustomMiddleware
isn't serving theContent-Security-Policy
header anymore, this come from https://whitenoise.readthedocs.io/en/stable/changelog.html#id3Comments on various packages
newrelic
record_exception
withnotice_error
as requested hereadd_custom_parameter
withadd_custom_attribute
as requested heremozlog
I've bump the package but I didn't find any release notes...
importlib-metadata
Removed because it was unused in the repository code
typed-ast
Removed because it was unused in the repository code
mozci
[cache]
because of Installation of mozci via pip is broken mozci#895taskcluster.aio
import resolution with the following error:coreapi
CoreAPI auto schema which was used to serve the DRF API documentation has been replaced by OpenAPI. This new schema has to be served using a custom UI, here we picked ReDoc. See DRF documentation for more information.
There's definitely a certain amount of work to be done on the schema construction to make the new UI more pleasant to read and navigate.
In the meantime, API documentation is still available at the URL
/docs/
, while the new schema is available at/openapi/
(it was/docs/schema.js
before).