Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 14.0.0 #64

Closed
stof opened this issue Mar 18, 2022 · 9 comments · Fixed by #65
Closed

Update to 14.0.0 #64

stof opened this issue Mar 18, 2022 · 9 comments · Fixed by #65

Comments

@stof
Copy link

stof commented Mar 18, 2022

Upstream 14.0.0 relase which supports emojis from Unicode 14

@atoponce
Copy link

atoponce commented Apr 9, 2022

@nolanlawson
Copy link

For anyone looking for a quick fix, I used this PR (#65) plus some fixes (on my machine, it only worked with Node v10) to build the TTF file. Here is the TTF file and here is a demo.

@atoponce
Copy link

Just for future devs coming by this issue, following @nolanlawson's suggestion of using PR #65, I can execute make successfully with Node.js versions v10.24.1 and v11.15.0.

The build fails with Node.js versions v12.22.12, v13.14.0, v14.19.3, v15.14.0, v16.15.0, v17.9.0, & v18.2.0 with the following error:

/tmp/node-v18.2.0-linux-x64/bin/node layerize.js twe-svg.zip overrides extras build Twemoji\ Mozilla
fs.js:47
} = primordials;
    ^

ReferenceError: primordials is not defined
    at fs.js:47:5
    at req_ (/home/atoponce/src/twemoji-colr/node_modules/natives/index.js:143:24)
    at Object.req [as require] (/home/atoponce/src/twemoji-colr/node_modules/natives/index.js:55:10)
    at Object.<anonymous> (/home/atoponce/src/twemoji-colr/node_modules/fstream/node_modules/graceful-fs/fs.js:1:37)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Module._load (node:internal/modules/cjs/loader:827:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)

Node.js v18.2.0
make: *** [Makefile:52: build/codepoints.js] Error 1

@hpreusse
Copy link

Just for future devs coming by this issue, following @nolanlawson's suggestion of using PR #65, I can execute make successfully with Node.js versions v10.24.1 and v11.15.0.

The build fails with Node.js versions v12.22.12, v13.14.0, v14.19.3, v15.14.0, v16.15.0, v17.9.0, & v18.2.0 with the following error:

I tend to report this as separated issue, as updating to latest version of the Emoji fonts won't solve it.

@win98se
Copy link
Contributor

win98se commented Jun 13, 2022

@nolanlawson @atoponce @hpreusse
In my submitted PR #65, I've stated in additional notes that -

On Node versions 16 and 17 (should work on all versions >=12 I guess), before running npm install (as in “Getting started” part in README.md), I have to run npm install --package-lock-only --ignore-scripts && npx npm-force-resolutions so that the make step (as in “Building the font” part also in README.md) will run successfully.

Maybe try the above as a workaround and see if it works?

@kguelzau
Copy link

kguelzau commented Jul 1, 2022

Does anybody know when this will be merged/released and if there is a corresponding ticket to use the new version in firefox?

@win98se
Copy link
Contributor

win98se commented Jul 2, 2022

As the PR creator (refer #65), I am waiting for it too. Meanwhile, you can just replace the Firefox's included font file (yikes for Microsoft Windows 10/11 UWP users though) with your own generated font file for the time being.

@Sav22999
Copy link

Sav22999 commented Sep 3, 2022

@nolanlawson this apparently doesn't work correctly on Mac OS. You know why?

@Sav22999
Copy link

On MacOS the previous version of this font family didn't work. Does this version work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants