-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: newer emoji and flags on Firefox on Windows #271
Conversation
📊 Tachometer Benchmark ResultsSummarybenchmark-total
Resultsemoji-picker-element-database-interactions
emoji-picker-element-first-load
emoji-picker-element-second-load
|
Size Change: 0 B Total Size: 41.8 kB ℹ️ View Unchanged
|
At the risk of chipping in unsolicited: I'm not 100% convinced that this is the right solution, because the user tends to pick an emoji into something - likely a text field of sorts, and it'll be a quirky experience for the emoji picker to show Twemojis everywhere, but then when an emoji is picked, it'll show in the Segoe UI style again which looks quite different, to the point that I can imagine some users think they picked the wrong emoji. I guess the workaround is for every app that uses emoji-picker-element to also add That, or I'm missing something :-) |
@eteeselink No problem with unsolicited feedback. 🙂 Yeah, it's a bit unfortunate, but the best way to ensure that your app renders exactly the same as An alternative you might imagine is to just not specify the Also, that causes Firefox on Windows to still do the mixed font behavior: I should really document this, though, since it's not at all obvious. |
In related news, it looks like Noto has released v14 whereas Mozilla Twemoji hasn't yet updated to v14 (mozilla/twemoji-colr#64). So possibly some Linux users are going to get a mix of Twemoji and Noto. I'd still prefer putting Twemoji first, though, because I don't want to play a cat-and-mouse game of updating the list of fonts every time a browser or OS does a release. |
Previous discussion: #268 (comment)
On Windows and Linux (but apparently not MacOS or Android), Firefox ships its own
"Twemoji Mozilla"
font. On Windows in particular, the conflicts with the existing Segoe UI font, causing several issues:This PR changes the order of fonts in the
font-family
list to put"Twemoji Mozilla"
first. I'm just going to assume that, if Mozilla is bundling their own font in the browser, then they know what they're doing and they're shipping emoji updates faster than the underlying OS.This assumption will break if the underlying OS emoji (i.e. Noto Emoji on Linux and Segoe UI on Windows) ever update faster than Mozilla Twemoji, but I guess we have to take that risk. Today Mozilla Twemoji is on v13.1, Segoe is on v12.1 (on my Windows 10 21H2), and Noto is on v13.1 (on my Ubuntu 20.04).
Before:
After:
MacOS and Android are unchanged because Mozilla doesn't ship Twemoji there. Linux is unchanged because we already listed Twemoji before Noto.