This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Use SVGs and clip-path instead of images for icons.
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, didn't realize these PRs were piling up! Merging... |
jaredhirsch
added a commit
that referenced
this pull request
Dec 1, 2015
Use SVGs and `clip-path` instead of images for icons.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is pretty cool. Instead of external base64 image assets (SVG or PNG), we instead include a single SVG element in the index template (they have to be in markup, unfortunately, for build process reasons) and use the CSS
clip-pathproperty to hide a solid block of background color. This will save bytes + memory, and also let us change the color of the icons by simply manipulating (+ transitioning!) that background color.This addresses issue #75.
r? @6a68