This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Make the box-model layout-view work with ios #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ |
captainbrosset
force-pushed
the
ios-box-model
branch
from
01aa9ef
to
f58941b
Compare
|
Rebased this PR. Merging now. |
captainbrosset
added a commit
that referenced
this pull request
Oct 30, 2014
Make the box-model layout-view work with ios
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On firefox, we're using getBoundingClientRect + computed style to determine the width/height + margin/padding/border.
On chrome, we're using the
DOM.getBoxModelcommand and then transform the returned quads in something that our layout-view can understand.On ios, this command doesn't exist, so instead, we fall back to doing the same as on firefox:
CSS.getComputedStyleForNodecommand).