refactor: Append binaryArgs instead of prepend

mozilla · Mar 28, 2019 · 28cb262 · 28cb262
1 parent 117553b
commit 28cb262
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/extension-runners/firefox-desktop.js b/src/extension-runners/firefox-desktop.js
@@ -217,21 +217,27 @@ export class FirefoxDesktopExtensionRunner {
       startUrl,
       firefoxApp,
       firefoxClient,
-      args = [],
+      args,
     } = this.params;
 
+    const binaryArgs = [];
+
     if (browserConsole) {
-      args.push('-jsconsole');
+      binaryArgs.push('-jsconsole');
     }
     if (startUrl) {
       const urls = Array.isArray(startUrl) ? startUrl : [startUrl];
       for (const url of urls) {
-        args.push('--url', url);
+        binaryArgs.push('--url', url);
       }
     }
 
+    if (args) {
+      binaryArgs.push(...args);
+    }
+
     this.runningInfo = await firefoxApp.run(this.profile, {
-      firefoxBinary, args,
+      firefoxBinary, args: binaryArgs,
     });
 
     this.runningInfo.firefox.on('close', () => {