feat: adds binaryArgs

mozilla · Mar 16, 2019 · 420b395 · 420b395
1 parent 7311faa
commit 420b395
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,6 @@
 # OSX
 .DS_Store
+.idea
 
 # Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
 .grunt

diff --git a/src/cmd/run.js b/src/cmd/run.js
@@ -36,6 +36,7 @@ export type CmdRunParams = {|
   sourceDir: string,
   startUrl?: Array<string>,
   target?: Array<string>,
+  binaryArgs?: Array<string>,
 
   // Android CLI options.
   adbBin?: string,
@@ -77,6 +78,7 @@ export default async function run(
     adbPort,
     adbDevice,
     firefoxApk,
+    binaryArgs,
   }: CmdRunParams,
   {
     buildExtension = defaultBuildExtension,
@@ -107,6 +109,7 @@ export default async function run(
     extensions: [{sourceDir, manifestData}],
     keepProfileChanges,
     startUrl,
+    binaryArgs,
     desktopNotifications,
   };
 

diff --git a/src/extension-runners/base.js b/src/extension-runners/base.js
@@ -16,6 +16,7 @@ export type ExtensionRunnerParams = {|
   profilePath?: string,
   keepProfileChanges: boolean,
   startUrl: ?string | ?Array<string>,
+  binaryArgs?: Array<string>,
 
   // Common injected dependencies.
   desktopNotifications: typeof defaultDesktopNotifications,

diff --git a/src/extension-runners/firefox-desktop.js b/src/extension-runners/firefox-desktop.js
@@ -217,10 +217,9 @@ export class FirefoxDesktopExtensionRunner {
       startUrl,
       firefoxApp,
       firefoxClient,
+      binaryArgs = [],
     } = this.params;
 
-    const binaryArgs = [];
-
     if (browserConsole) {
       binaryArgs.push('-jsconsole');
     }