-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add --chromium-pref
flag
#2912
base: master
Are you sure you want to change the base?
Conversation
@@ -66,6 +66,9 @@ describe('util/extension-runners/chromium', async () => { | |||
'--password-store=basic', | |||
'--use-mock-keychain', | |||
'--force-fieldtrials=*BackgroundTracing/default/', | |||
'--disable-hang-monitor', | |||
'--disable-prompt-on-repost', | |||
'--disable-domain-reliability', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were required after upgrading chrome-launcher, similar to #2825 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2912 +/- ##
===========================================
+ Coverage 0 99.31% +99.31%
===========================================
Files 0 32 +32
Lines 0 1759 +1759
===========================================
+ Hits 0 1747 +1747
- Misses 0 12 +12 ☔ View full report in Codecov by Sentry. |
f6cda7b
to
6442c6c
Compare
Rebased and fixed merge conflicts |
4d10f82
to
c8dea96
Compare
Rebased and fixed conflicts |
No conflicts present with Branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
@aklinker1 why not merge this pr? I still encounter the content script source map issues |
Only maintainers can merge PRs, and this hasn't been approved by one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@VersoriumX I appreciate your approvals, but since you're not a maintainer, you approving this more than once doesn't really help |
Sorry for the delay here - I've put this on my list of tasks to review. We are supportive of the requested capability here. |
@Rob--W no worries! Thanks for the update |
Overview
This closes #2899.
Add a new parameter,
--chromium-pref
, which lets users configure some profile settings when running theweb-ext run
command. For default preferences, I setextensions.ui.developer_mode=true
so you don't have to toggle the developer mode switch every time you run an extension on chromium.web-ext/src/extension-runners/chromium.js
Lines 30 to 32 in 9d0512a
I also had to upgrade
chromium-launcher
to v1.1.0 (see GoogleChrome/chrome-launcher#323), so this replaces #2825 and #2901.web-ext/src/extension-runners/chromium.js
Lines 210 to 219 in 9d0512a
Manual Testing
Here's the commands I ran to do manual testing: