Merge branch 'master' into enable-developer-mode

.circleci/config.yml

@@ -24,11 +24,13 @@ references:
   # set of nodejs versions that should be tested.
   # The nodejs version set as `nodejs_current` is the one used to
   # release the package on npm.
+  #
+  # See https://nodejs.org/en/about/previous-releases for updates to nodejs versions.
   nodejs_versions:
     # nvm-windows wants a full Node version, not just `<major>.<minor>`.
-    - &nodejs_current "16.14.2"
-    - &nodejs_next "18.15"
-    - &nodejs_experimental "19.3"
+    - &nodejs_current "18.19.0"
+    - &nodejs_next "20.11.0"
+    - &nodejs_experimental "21.5"
 
   nodejs_enum: &nodejs_enum
     type: enum
@@ -173,13 +175,24 @@ jobs:
           node_env: test
       ## Skip code coverage and the additional legacy bundling tests on jobs
       ## running on the next nodejs versions.
-      - unless:
+      - when:
           condition:
-            equal: [*nodejs_current, << parameters.nodejs >>]
+            equal: [*nodejs_next, << parameters.nodejs >>]
+          steps:
+            - run:
+                  name: run linting checks and unit tests
+                  command: npm run test
+            - run_functional_tests
+      ## Allow npm run test to fail when running on nodejs experimental.
+      # TODO(https://github.com/mozilla/web-ext/issues/3015): change this to do not
+      # allow failures on nodejs 21 once fixed by a testdouble dependency update.
+      - when:
+          condition:
+            equal: [*nodejs_experimental, << parameters.nodejs >>]
           steps:
             - run:
-                name: run linting checks and unit tests
-                command: npm run test
+                  name: run linting checks and unit tests (but allow failure)
+                  command: npm run test || echo "NOTE - Unit tests failed, but allowed to fail on nodejs experimental"
             - run_functional_tests
       ## Steps only executed in jobs running on the current nodejs version.
       - when:

README.md

@@ -5,8 +5,6 @@ This is a command line tool to help build, run, and test
 
 [![CircleCI](https://circleci.com/gh/mozilla/web-ext.svg?style=svg)](https://circleci.com/gh/mozilla/web-ext)
 [![codecov](https://codecov.io/gh/mozilla/web-ext/branch/master/graph/badge.svg)](https://codecov.io/gh/mozilla/web-ext)
-[![Dependency Status](https://david-dm.org/mozilla/web-ext.svg)](https://david-dm.org/mozilla/web-ext)
-[![devDependency Status](https://david-dm.org/mozilla/web-ext/dev-status.svg)](https://david-dm.org/mozilla/web-ext#info=devDependencies)
 [![npm version](https://badge.fury.io/js/web-ext.svg)](https://badge.fury.io/js/web-ext)
 
 Ultimately, it aims to support browser extensions in a standard, portable,
@@ -16,7 +14,7 @@ cross-platform way. Initially, it will provide a streamlined experience for deve
 ## Documentation
 
 - [Getting started with web-ext][web-ext-user-docs]
-- [Command reference](https://extensionworkshop.com/documentation/develop/web-ext-command-reference)
+- [Command reference](https://extensionworkshop.com/documentation/develop/web-ext-command-reference/)
 
 Here are the commands you can run. Click on each one for detailed documentation or use `--help` on the command line, such as `web-ext build --help`.
 
@@ -76,7 +74,7 @@ version on the command line with this:
 
 You'll need:
 
-- [Node.js](https://nodejs.org/en/), 16.0.0 or higher
+- [Node.js](https://nodejs.org/en/) (current [LTS](https://github.com/nodejs/LTS))
 - [npm](https://www.npmjs.com/), 8.0.0 or higher is recommended
 
 Optionally, you may like: