This repository has been archived by the owner on Apr 1, 2019. It is now read-only.
Make proxy port an optional suffix for each *Proxy capability #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As given by the spec the proxy port is no longer a separate capability, but an optional part of ftpProxy, httpProxy, sslProxy, and socksProxy.
To add a socks proxy the socks version is a required capability. This patch adds the handling of the capability.
AutomatedTester
approved these changes
Aug 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the correct handling of the proxy ports which are now part of the proxy host capability. By doing that a lot of not needed code can be removed, which also makes our handling more stable.
This change provides basic unit tests but I will add more detailed wdspec tests later when the refactoring is getting done.
Closes #115.
This change is