Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

[regression] It is possible to delete the first page in a project #443

Closed
Pomax opened this issue Jul 31, 2015 · 1 comment · Fixed by #450
Closed

[regression] It is possible to delete the first page in a project #443

Pomax opened this issue Jul 31, 2015 · 1 comment · Fixed by #450

Comments

@Pomax
Copy link
Contributor

Pomax commented Jul 31, 2015

STR

  • create a new project
  • select the only page there is to select
  • the "delete" icon is visible, tap it
  • you now have a project without pages =x
@Pomax Pomax changed the title It is possible to delete the first page in a project [regression] It is possible to delete the first page in a project Jul 31, 2015
@Pomax
Copy link
Contributor Author

Pomax commented Jul 31, 2015

git bisect result:

03e9577c8624cbae86993bf683fc91bf3fe24b6f is the first bad commit
commit 03e9577c8624cbae86993bf683fc91bf3fe24b6f
Author: Kate Hudson <k88hudson@gmail.com>
Date:   Thu Jul 23 11:45:42 2015 -0400

    [#386] Restore zoom out button for edit mode

:040000 040000 b14b68b6a9a12e6535262faa89dad9598bc01bf7 ab05b719c965d7c785ba0132abc4d5cd65d38448 M  src

@k88hudson any idea if we lost a check to see if the delete button needed hiding based on pages.length?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants