Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

Integrate activity search #49

Merged
merged 12 commits into from
Jun 26, 2014
Merged

Conversation

fuzzyfox
Copy link
Contributor

This adds the ability to search for activities and select the ones you wish to use. Activities can be reordered + removed once selected.

This PR should be dealt w/ after pull #47

Fixes #25

**Broken:**
Main content no longer editable. Need to split input into constiuent
blocks and deal w/ independantly.

**Temp:**
Kit template (public/templates/kit.html) is a temp fix till nunjucks
templates for kits exists in mozilla/webmaker-kits
@fuzzyfox
Copy link
Contributor Author

Steps to test:

  • get running w/ grunt
  • load in browser localhost:1111
  • search for an activity w/ simple keywords (e.g. 'spectrogram', 'mozilla', 'privacy')
  • click on thumbnail of a result to "select" it
    • select a few from different searches
  • visually check that the agenda in the preview is updating
  • reorder the selection by dragging an item up/down the list
    • check this gets reflected in preview once drag is complete
  • click build and check the output contains no JSON

@fuzzyfox
Copy link
Contributor Author

note: this would solve issue #33 and #2

@simonwex simonwex removed this from the Heartbeat 2: A Functional System milestone Jun 26, 2014
agenda = JSON.parse( agenda );
=======
var agenda = JSON.parse( $( '#kitAgenda' ).val().trim() );
>>>>>>> integrate activity search
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you committed a merge conflict.

@simonwex simonwex merged commit f544d67 into mozilla:develop Jun 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README.md with latest install/getting started instructions
2 participants