Skip to content
This repository has been archived by the owner on Jan 25, 2018. It is now read-only.

Process a Boku success redirect (bug 987841) #431

Merged
merged 1 commit into from
Apr 23, 2014

Conversation

kumar303
Copy link
Contributor

No description provided.

# the payment provider changed their URL parameters.
log.info('no transaction found for provider {p}; url: {u}'
.format(p=helper.provider.name, u=request.get_full_path()))
return HttpResponseNotFound()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't remember, but the transaction is also in the session? if so, is it worth checking to ensure its the correct transaction?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait you do that in transaction status

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't do more than get the transaction ID from the Boku query string and expose it to the UI. I could require it to be in the session but it seems maybe overkill.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the JSON view that gets actual transaction data checks the session

@andymckay
Copy link
Contributor

r+wc

@kumar303
Copy link
Contributor Author

I found a way to test this locally and it's not working! Let me dig in...

@kumar303
Copy link
Contributor Author

This is working for me locally now but I can't get server notifications to my localhost so it may not be fully working.

@kumar303
Copy link
Contributor Author

@muffinresearch I had to re-jigger the UI here, r for just the JavaScript bits?

@@ -493,6 +493,8 @@
'ajax_timeout': 45000,
# Wait timeout (Default 60s).
'wait_timeout': 60000,
# Poll interval (milleseconds) while waiting for something to happen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@muffinresearch
Copy link
Contributor

@muffinresearch I had to re-jigger the UI here, r for just the JavaScript bits?

The JS changes lgtm, but I think this is another one that's going to be easiest to test when on stage.

kumar303 added a commit that referenced this pull request Apr 23, 2014
Process a Boku success redirect (bug 987841)
@kumar303 kumar303 merged commit e1aaebc into mozilla:master Apr 23, 2014
@kumar303 kumar303 deleted the success branch April 23, 2014 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants