This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
We only document use of HS256, no need for others #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with self.settings(SUPPORTED_JWT_ALGORITHMS=['HS256']): | ||
| res = self.post( | ||
| request_kwargs={'jwt_kwargs': {'algorithm': 'none'}}) | ||
| eq_(res.status_code, 400) |
There was a problem hiding this comment.
Do we give any more feedback than this? Just a 400 seems pretty tough to debug.
There was a problem hiding this comment.
oh yeah, I forgot this is a standard JSON API response so we have a readable error code. Thanks.
|
It would be nice to get a better error than just r+ |
kumar303
added a commit
that referenced
this pull request
Mar 25, 2015
We only document use of HS256, no need for others
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.