Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
Removed conditional to not paginate featured addons
Browse files Browse the repository at this point in the history
  • Loading branch information
@robhudson
robhudson committed Oct 13, 2011
1 parent cb87ec8 commit 5d53568
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions apps/browse/templates/browse/extensions.html
View file
Expand Up @@ -16,9 +16,7 @@ <h1>{{ title }}</h1>
<div class="items">
{{ impala_addon_listing_items(addons.object_list, sorting, src=src) }}
</div>
{% if sorting != 'featured' %}
{{ addons|impala_paginator }}
{% endif %}
{{ addons|impala_paginator }}
</div>
</section>
{% endblock %}

3 comments on commit 5d53568

@jbalogh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I knew the bug number!

If this list is random the I don't think we can paginate. By the time you get to page 2 the list may have reordered itself and you may not get to see all the other add-ons.

@cvan
Copy link
Contributor

@cvan cvan commented on 5d53568 Oct 13, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this. Was it https://bugzilla.mozilla.org/show_bug.cgi?id=664047?

@robhudson
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spaced on the bug number in the commit, but it's https://bugzilla.mozilla.org/show_bug.cgi?id=691831

Would a better fix be to paginate by the addons.count() so all featured addons fit on a single page? 62 seems like a lot, however.

Please sign in to comment.