Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
point language packs to remora and fix the title (bug 564516)
Browse files Browse the repository at this point in the history
  • Loading branch information
jbalogh committed May 7, 2010
1 parent bf7ee36 commit 61a419a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
8 changes: 5 additions & 3 deletions apps/amo/helpers.py
Expand Up @@ -72,17 +72,19 @@ def sidebar(app):
types = [Type(_('Collections'), base + 'collections/')]
shown_types = {
amo.ADDON_PERSONA: base + 'personas/',
amo.ADDON_DICT: urlresolvers.reverse('browse.language_tools'),
amo.ADDON_DICT: base + 'browse/type:3',
# amo.ADDON_DICT: urlresolvers.reverse('browse.language_tools'),
amo.ADDON_SEARCH: base + 'browse/type:4',
amo.ADDON_PLUGIN: base + 'browse/type:7',
amo.ADDON_THEME: base + 'browse/type:2/cat:all?sort=popular',
# TODO(davedash): Remove comment after remora goes away:
# amo.ADDON_THEME: urlresolvers.reverse('browse.themes'),
}
titles = dict(amo.ADDON_TYPES,
**{amo.ADDON_DICT: _('Dictionaries & Language Packs')})
for type_, url in shown_types.items():
if type_ in app.types:
name = amo.ADDON_TYPES[type_]
types.append(Type(name, url))
types.append(Type(titles[type_], url))

return categories, sorted(types, key=lambda x: x.name)

Expand Down
7 changes: 7 additions & 0 deletions apps/amo/tests/test_views.py
Expand Up @@ -190,3 +190,10 @@ def test_jsi18n_caching():
fmt = '%a, %d %b %Y %H:%M:%S GMT'
expires = datetime.strptime(response['Expires'], fmt)
assert (expires - datetime.now()).days >= 365


def test_dictionaries_link():
doc = pq(test.Client().get('/', follow=True).content)
# This just failed because you dropped the remora url.
link = doc('#categoriesdropdown a[href$="type:3"]')
eq_(link.text(), 'Dictionaries & Language Packs')

0 comments on commit 61a419a

Please sign in to comment.