Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
Merge pull request #1282 from davidbgk/928545-right-localization
Browse files Browse the repository at this point in the history
 Less confusing L10n around deleting payments (bug 928545)
  • Loading branch information
davidbgk committed Oct 24, 2013
2 parents 3aa24c4 + f41e9d6 commit 9673593
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions media/js/devreg/payments-manage.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ define('payments-manage', ['payments'], function(payments) {
var isPlural = data['app-names'].indexOf(spliter) < 0;
var $confirm_delete_overlay = payments.getOverlay('payment-account-delete-confirm');
$confirm_delete_overlay.find('p').text(
format('Warning: deleting payment account "{0}" ' +
'will move {1} associated {2} to an incomplete status ' +
'and {3} will no longer be available for sale:',
[data['name'],
ngettext('that', 'those', isPlural),
ngettext('app', 'apps', isPlural),
ngettext('it', 'they', isPlural)]));
// L10n: This sentence introduces a list of applications.
format(ngettext('Warning: deleting payment account "{0}" ' +
'will move that associated app to an incomplete status ' +
'and it will no longer be available for sale:',
'Warning: deleting payment account "{0}" ' +
'will move those associated apps to an incomplete status ' +
'and they will no longer be available for sale:',
isPlural), [data['name']]));
$confirm_delete_overlay.find('ul')
.html('<li>' + escape_(data['app-names']).split(spliter).join('</li><li>') + '</li>');
$confirm_delete_overlay.on('click', 'a.payment-account-delete-confirm', _pd(function() {
Expand Down

0 comments on commit 9673593

Please sign in to comment.