fix float to decimal conversion in stats

mozilla · Jul 19, 2012 · d70c4f4 · d70c4f4
1 parent ce270de
commit d70c4f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/mkt/stats/search.py b/mkt/stats/search.py
@@ -203,7 +203,7 @@ def cut(revenue):
     """
     Takes away Marketplace's cut from developers' revenue.
     """
-    return Decimal(round(Decimal(revenue) * Decimal(MKT_CUT), 2))
+    return Decimal(str(round(revenue * MKT_CUT, 2)))
 
 
 def handle_kwargs(q, field, kwargs, join_field=None):

diff --git a/mkt/stats/tests/test_tasks.py b/mkt/stats/tests/test_tasks.py
@@ -1,4 +1,5 @@
 import datetime
+from decimal import Decimal
 import random
 
 from django.utils import unittest
@@ -428,7 +429,7 @@ def test_basic(self):
 class TestCut(unittest.TestCase):
 
     def test_basic(self):
-        eq_(cut(0), 0)
-        eq_(cut(1), .7)
-        eq_(cut(10), 7)
-        eq_(cut(33), 23.10)
+        eq_(cut(0), Decimal(str(0)))
+        eq_(cut(1), Decimal(str(.7)))
+        eq_(cut(10), Decimal(str(7)))
+        eq_(cut(33), Decimal(str(23.10)))