Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
Fix custom icon uploads (bug 730309)
Browse files Browse the repository at this point in the history
We are no longer using #icons_default in the layout and that selector
looked kinda broken anyway.
  • Loading branch information
kumar303 committed Feb 24, 2012
1 parent 6e72552 commit e780410
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion media/js/devreg/devhub.js
Expand Up @@ -537,7 +537,7 @@ function initUploadIcon() {
$('#id_unsaved_icon_data').val(file.dataURL);

$('#icons_default input:checked').attr('checked', false);
$('input[name="icon_type"][value="'+file.type+'"]', $('#icons_default'))
$('input[name="icon_type"][value="'+file.type+'"]')
.attr('checked', true);
},

Expand Down

1 comment on commit e780410

@kumar303
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potch any reason why we might need this? Removing it fixed icon uploads and I tested all submission/edit scenarios. We're not using id="icons_default" anymore.

Please sign in to comment.