Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
use absolute urls for files (bug 609187)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeff Balogh committed Nov 4, 2010
1 parent 8196f5e commit e8aa05b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
7 changes: 7 additions & 0 deletions apps/api/tests/test_legacy.py
Expand Up @@ -228,6 +228,13 @@ def test_double_site_url(self):
response = make_call('addon/4664', version=1.5)
self.assertNotContains(response, settings.SITE_URL + settings.SITE_URL)

def test_absolute_install_url(self):
response = make_call('addon/4664', version=1.2)
doc = pq(response.content)
url = doc('install').text()
expected = '%s/firefox/downloads/file' % settings.SITE_URL
assert url.startswith(expected), url

def test_15_addon_detail(self):
"""
For an api>1.5 we need to verify we have:
Expand Down
5 changes: 3 additions & 2 deletions apps/files/models.py
Expand Up @@ -34,9 +34,10 @@ def amo_platform(self):

def get_url_path(self, app, src):
# TODO: remove app
from amo.helpers import urlparams
from amo.helpers import urlparams, absolutify
url = reverse('downloads.file', args=[self.id]) + self.filename
return urlparams(url, src=src)
# Firefox's Add-on Manager needs absolute urls.
return absolutify(urlparams(url, src=src))

def generate_filename(self, extension='xpi'):
"""
Expand Down

0 comments on commit e8aa05b

Please sign in to comment.