put the |f against the string (bug 564140)

mozilla · May 6, 2010 · efd6451 · efd6451
1 parent e386ab9
commit efd6451
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/apps/addons/templates/addons/review_add_box.html b/apps/addons/templates/addons/review_add_box.html
@@ -57,7 +57,7 @@ <h3>{{ _('What do you think?') }}</h3>
     <p><a href="{{ remora_url('/pages/review_guide') }}">{{ _('Review Guidelines') }}</a></p>
     <p>
       {# TODO reverse url #}
-      <a href="{{ remora_url('/reviews/add/{0}')|f(addon.id) }}">
+      <a href="{{ remora_url('/reviews/add/{0}'|f(addon.id)) }}">
         {{ _('Detailed Review') }}</a>
     </p>
 

diff --git a/apps/addons/tests/test_views.py b/apps/addons/tests/test_views.py
@@ -300,6 +300,14 @@ def test_remove_tag_button(self):
         doc = pq(r.content)
         assert len(doc('#tags li input.removetag'))
 
+    def test_detailed_review_link(self):
+        # TODO(jbalogh): use reverse when we drop remora.
+        self.client.login(username='regular@mozilla.com', password='password')
+        r = self.client.get(reverse('addons.detail', args=[3615]))
+        doc = pq(r.content)
+        href = doc('#review-box a[href*="reviews/add"]').attr('href')
+        assert href.endswith('/reviews/add/3615'), href
+
 
 class TestTagsBox(test_utils.TestCase):
     fixtures = ['base/addontag']