Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
new welcome message (bug 678788)
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Van committed Sep 7, 2011
1 parent e5d3c2c commit f0c7346
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 5 deletions.
12 changes: 12 additions & 0 deletions apps/addons/tests/test_views.py
Expand Up @@ -62,6 +62,18 @@ def test_thunderbird(self):
doc = pq(r.content)
eq_('Add-ons for Thunderbird', doc('title').text())

def test_welcome_msg(self):
r = self.client.get('/en-US/firefox/')
welcome = pq(r.content)('#site-welcome').remove('a.close')
eq_(welcome.text(),
'Welcome to Firefox Add-ons. Choose from thousands of extra '
'features and styles to make Firefox your own.')
r = self.client.get('/en-US/thunderbird/')
welcome = pq(r.content)('#site-welcome').remove('a.close')
eq_(welcome.text(),
'Welcome to Thunderbird Add-ons. Add extra features and styles to '
'make Thunderbird your own.')

def test_no_unreviewed(self):
response = self.client.get(self.base_url)
addon_lists = 'popular featured hotness personas'.split()
Expand Down
3 changes: 1 addition & 2 deletions media/css/impala/header.less
Expand Up @@ -339,8 +339,7 @@ button.search-button {
border: 2px solid #e3873b;
.border-radius(10px);
display: none;
font-family: Arial, sans-serif;
font-size: 14px;
font: 14px/16px Arial, sans-serif;
position: relative;
margin-top: 22px;
h3, p {
Expand Down
13 changes: 10 additions & 3 deletions templates/impala/base.html
Expand Up @@ -120,9 +120,16 @@
{# L10n: {0} is an application, such as Firefox. #}
<h3>{{ _('Welcome to {0} Add-ons.')|f(APP.pretty) }}</h3>
<p>
{% trans app=APP.pretty %}
Choose from thousands of extra features and styles for {{ app }}.
{% endtrans %}
{% if APP == amo.FIREFOX %}

This comment has been minimized.

Copy link
@jbalogh

jbalogh Sep 7, 2011

Contributor

Should this go for mobile too? (@fligtar)

This comment has been minimized.

Copy link
@fligtar

fligtar Sep 8, 2011

Contributor

No, we only have like 60 add-ons for mobile.

{% trans %}
Choose from thousands of extra features and styles to make
Firefox your own.
{% endtrans %}
{% else %}
{% trans app=APP.pretty %}
Add extra features and styles to make {{ app }} your own.
{% endtrans %}
{% endif %}
</p>
<a href="#" class="close">{{ _('Close') }}</a>
</div>
Expand Down

0 comments on commit f0c7346

Please sign in to comment.