fix reviews stuff (bug 668407)

mozilla · Jun 30, 2011 · f1242ad · f1242ad
1 parent c1a5d8d
commit f1242ad
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 11 deletions.
diff --git a/apps/addons/templates/addons/impala/details.html b/apps/addons/templates/addons/impala/details.html
@@ -149,10 +149,12 @@ <h2>{{ _('About this Add-on') }}</h2>
 {% endcache %} {# cache addon #}
 
 <aside class="secondary addon-reviews c">
-  <div>
-    {{ addon.average_rating|stars }}
-    {{ _('Average') }}
-  </div>
+  {% if reviews %}
+    <div>
+      {{ addon.average_rating|stars }}
+      {{ _('Average') }}
+    </div>
+  {% endif %}
   {% include "reviews/grouped_ratings.html" %}
   {% set amo_user = request.amo_user if user.is_authenticated() else None %}
   {% if not addon.has_author(amo_user) %}

diff --git a/apps/addons/templates/addons/impala/review_list_box.html b/apps/addons/templates/addons/impala/review_list_box.html
@@ -34,13 +34,13 @@ <h3>
       </p>
     {% endif %}
   {% else %}
-    <div class="review">
-      <h3>{{ _('This add-on has not yet been reviewed.') }}</h3>
-      <p>
-        <a href="{{ url('reviews.add', addon.slug) }}">
-          {{ _('Be the first to write a review!') }}
-        </a>
-      </p>
+    <div class="review no-reviews">
+      <h3>
+        {% trans url = url('reviews.add', addon.slug) %}
+          This add-on has not yet been reviewed.
+          <a href="{{ url }}">Be the first!</a>
+        {% endtrans %}
+      </h3>
     </div>
   {% endif %}
 {% endcache %}
diff --git a/media/css/impala/addon_details.less b/media/css/impala/addon_details.less
@@ -246,6 +246,12 @@
 
 #reviews .review {
     border-bottom: 1px dotted #C9DDF2;
+    &.no-reviews {
+        border-bottom: 0;
+        h3 {
+            font-style: normal;
+        }
+    }
     padding: 1em 0;
     h3 {
         color: #333333;