Surface manifest errors to form (bug 749832)

mozilla · May 2, 2012 · f9267d0 · cvan · May 2, 2012 · cvan
1 parent 7829435
commit f9267d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/mkt/developers/templates/developers/apps/edit/basic.html b/mkt/developers/templates/developers/apps/edit/basic.html
@@ -57,6 +57,7 @@ <h2>
           <td>
             {% if editable %}
               <input type="text" name="manifest_url"{% if not action_allowed('Admin', '%') %} readonly{% endif %} value="{{ addon.manifest_url }}">
+              {{ form.manifest_url.errors }}
               <p class="note">
                 {% with email='app-reviews@mozilla.org' %}
                   Manifest URLs cannot be changed after your app has been

diff --git a/mkt/developers/tests/test_views_edit.py b/mkt/developers/tests/test_views_edit.py
@@ -210,6 +210,14 @@ def test_view_manifest_url_default(self):
         # non-admins.
         eq_(self.get_webapp().manifest_url, self.webapp.manifest_url)
 
+    def test_view_edit_manifest_url_empty(self):
+        # Empty manifest should throw an error.
+        url = ''
+        r = self.client.post(self.edit_url, self.get_dict(manifest_url=url))
+        form = r.context['form']
+        assert 'manifest_url' in form.errors
+        assert 'This field is required' in form.errors['manifest_url'][0]
+
     @mock.patch('devhub.tasks.urllib2.urlopen')
     def test_view_admin_edit_manifest_url(self, mock_urlopen):
         mock_urlopen.return_value = response_mock