Bug 726853: It's Tabzilla Time for AMO #1030
Conversation
|
This is probably best for @ngokevin to review? |
| @@ -5,15 +5,12 @@ | |||
| } | |||
|
|
|||
| html, body { | |||
| .height-calc(~'100% - 2px', 100%); | |||
| height: 100%; | |||
There was a problem hiding this comment.
this is to offset the 2px border
There was a problem hiding this comment.
Per http://bedrock.readthedocs.org/en/latest/tabzilla.html#requirements
An element other than the <body> should add a 2 pixel white border to the top of the page (border-top: 2px solid #fff;)
I move this border to #outer-wrapper
There was a problem hiding this comment.
there's gotta be a better way to do this than adding another element - consider using :before/:after on html/body
|
please fix up all the indentation - not sure what changed in those blocks |
|
Also you can see https://github.com/mozilla/zamboni/pull/1030/files?w=1 for the non-whitespace changes |
|
what about the Developer Hub pages? |
|
If adding extra |
|
@l-hedgehog do you have any open questions on this? Trying to make sure we're not holding this up |
|
@clouserw no, just got distracted from this, I'll update the PR before next week. |
| @@ -18,6 +18,9 @@ | |||
| rel="search" type="application/opensearchdescription+xml" | |||
| href="{{ url('amo.opensearch') }}" /> | |||
|
|
|||
| {% block tabzilla_css %} | |||
| <link href="//mozorg.cdn.mozilla.net/media/css/tabzilla-min.css" rel="stylesheet" /> | |||
There was a problem hiding this comment.
Don't need the trailing slash.
<link href="//mozorg.cdn.mozilla.net/media/css/tabzilla-min.css" rel="stylesheet">
Also don't really need the tabzilla_css and tabzilla_js jinja blocks since there's no where right now where we are overriding.
|
Address the comments, fix the merge conflicts, and I'll merge it in. Thanks @l-hedgehog, safe travels. |
| @@ -1217,6 +1217,8 @@ def JINJA_CONFIG(): | |||
| CSP_ALLOW = ("'self'",) | |||
| CSP_IMG_SRC = ("'self'", STATIC_URL, | |||
| "https://www.google.com", # Recaptcha comes from google | |||
| "https://mozorg.cdn.mozilla.net", # Tabzilla | |||
There was a problem hiding this comment.
two spaces, not one, before the #
|
Here's a proposal considering reviews: #1244 |
|
@ngokevin, sorry, still recovering from jetlag ... |
|
Np, thank you. And good morning 🌅 |
Only the impala theme template and styles.
Works locally for the pages I manually checked.
[comments below from @ngokevin]:
This patch changes the AMO/devhub gray tab to be the new slide-down tab global across Mozilla sites (tabzilla).
Requirements
divto the base Zamboni and base impala templates.backgroundCSS rule fromhtmlto the wrapper so the background slides down with the pageborder-toprule from thebodyto the wrapper as per requirements