This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Make sure the extra translation queries follow db routing (bug 905887) #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| connections[dbname].queries = [] | ||
|
|
||
| with nested(mock.patch('multidb.get_slave', lambda: 'slave-2'), | ||
| use_master): |
There was a problem hiding this comment.
Could we add a note that under Python 2.7 this is probably better as the multiple manager form of with? The docs say this is "quirky".
|
I've read up on |
diox
added a commit
that referenced
this pull request
Sep 18, 2013
Make sure the extra translation queries follow db routing (bug 905887)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=905887
This should fix translations being empty for a small amount of time when creating a collection or an app, at least when creating using the API (since it pins its queries to master when authenticated)
A later fix would be to send the db currently used to the transformers to make them follow that, but that requires a django-queryset-transform patch.
Edit: bonus read, how translations work in Zamboni : https://gist.github.com/diox/e99d74a8e445032b49fa