This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Fix recaptcha on AMO (bugs 589359, 932514) #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | |||
| <p> | |||
| If this is hard to read, you can | |||
| <a href="#" id="recaptcha_different">try different words</a> or | |||
| <a href="#" id="recaptcha_audio">listen to something</a> instead. | |||
| <a href="#" id="recaptcha_audio">try a different type of challenge</a> instead. | |||
There was a problem hiding this comment.
is #recaptcha_audio the correct id then?
There was a problem hiding this comment.
Not the best ID, but it's fine.
|
r+ |
mattbasta
added a commit
that referenced
this pull request
Nov 20, 2013
Fix recaptcha on AMO (bugs 589359, 932514)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix manages to not change the entire login implementation to fix what otherwise happens to be an unending series of terrifically simple bugs.
cc @cvan, @ngokevin