This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Fix conflated payments.js-s (bug 951696) #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,490 @@ | |||
| (function() { | |||
There was a problem hiding this comment.
The reviewers stuff probably could've been its own commit, but I like the changes. I'll mark a TODO to trim this.
There was a problem hiding this comment.
Will be sweet once I rename devreg to mkt.
|
r+ Applied locally, reviewer tools still working. Payment changes are a simple restore. The refactoring of the bundles is good. |
|
We should all send a big digital hug to @potch for encouraging us to have an |
mattbasta
added a commit
that referenced
this pull request
Dec 18, 2013
Fix conflated payments.js-s (bug 951696)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
payments.jsand also moves any reviewer-only JS files into their own directory.I started marking what depends on what and duplicated
editors.jsto separate it out from the AMO editor dashboard. There's probably a lot of low-hanging fruit to trim up those files. That sounds like a job for @ngokevin, though.