This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
assert set_content_ratings triggers es reindex (bug 932324) #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1197,6 +1198,8 @@ def set_content_ratings(self, data): | |||
| if geodatas.exists(): | |||
| geodatas.update(region_de_usk_exclude=False) | |||
|
|
|||
| self.save() # Re-index. | |||
There was a problem hiding this comment.
Does this need to save anything to the db? B/c if not, you could call the index task directly. But if you do need a save this is fine.
|
r+wc |
|
thanks rob |
ngokevin
added a commit
that referenced
this pull request
Jan 28, 2014
assert set_content_ratings triggers es reindex (bug 932324)
| @@ -1177,11 +1177,14 @@ def set_content_ratings(self, data): | |||
| {<ratingsbodies class>: <rating class>, ...} | |||
|
|
|||
| """ | |||
| from . import tasks | |||
There was a problem hiding this comment.
Maybe, I saw it was being done everywhere else. I'll remove it later if it doesn't circle.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search view returns null content ratings for apps that do have content ratings. The index is out of date of such apps. Make sure to update the index whenever they update their content ratings.