Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

[There and Back Again] Theme reviewer tools to AMO to set up the Guillotine #1730

Merged
merged 3 commits into from Feb 6, 2014

Conversation

ngokevin
Copy link
Contributor

@ngokevin ngokevin commented Feb 5, 2014

  • Tests pass
  • Made editors.css a Stylus stylesheet to ease my pain, gave themes reviewer tools their own asset bundle
  • Keeping theme tools on Marketplace for now as a fallback tool in case this one breaks + for future use for wallpapers/ringtones review

screen shot 2014-02-05 at 9 44 07 am
screen shot 2014-02-05 at 9 44 15 am
screen shot 2014-02-05 at 9 44 25 am
screen shot 2014-02-05 at 9 44 48 am
screen shot 2014-02-05 at 9 44 38 am

@robhudson
Copy link
Member

Oh yeah 👶! I'll review hard first thing tomorrow morning.

def __init__(self, *args, **kwargs):
super(DeletedThemeLogForm, self).__init__(*args, **kwargs)
self.fields['search'].widget.attrs = {
# L10n: Descript of what can be searched for.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Description"?

@robhudson
Copy link
Member

r+wc

@cvan
Copy link
Contributor

cvan commented Feb 6, 2014

lol there's no way this works. that was way too quick

@ngokevin
Copy link
Contributor Author

ngokevin commented Feb 6, 2014

Giving myself 3:1 that it works, but I believe! 🙏

ngokevin added a commit that referenced this pull request Feb 6, 2014
[There and Back Again] Theme reviewer tools to AMO to set up the Guillotine
@ngokevin ngokevin merged commit 63a6dff into mozilla:master Feb 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants