This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Fix serverless inapp JWT: public_id (bug 1016685) #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar303
changed the title
| @@ -139,4 +141,5 @@ def product_data(self, contribution): | |||
| 'inapp_id': self.inapp.pk, | |||
| 'application_size': self.application_size(), | |||
| 'contrib_uuid': contribution.uuid, | |||
| 'public_id': self.addon().solitude_public_id, | |||
There was a problem hiding this comment.
Does the inapp product use the parent products public_id or does it need its own?
There was a problem hiding this comment.
I'm pretty sure it needs the parent product because it's used in webpay to get payment setup info. So far I've been able to start a Boku purchase with this patch but I have not completed it (that requires a hosted server).
| @@ -20,6 +20,11 @@ def get_product_jwt(product, contribution): | |||
| """Prepare a JWT for paid products to pass into navigator.pay()""" | |||
|
|
|||
| issued_at = calendar.timegm(time.gmtime()) | |||
| product_data = product.product_data(contribution) | |||
| if not product_data.get('public_id'): | |||
|
r+ |
kumar303
added a commit
that referenced
this pull request
May 28, 2014
Fix serverless inapp JWT: public_id (bug 1016685)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JaredKerim-Mozilla r?