Remove leftover AMO views, templates, template tags (bug 973140) #2112
Conversation
| @@ -156,72 +24,7 @@ def impala_addon_listing_header(context, url_base, sort_opts={}, selected=None, | |||
| return new_context(**locals()) | |||
There was a problem hiding this comment.
We can remove this also if we remove the conditional in mkt/developers/templates/developers/apps/dashboard.html.
There was a problem hiding this comment.
You mean the whole template tag? it's actually useful/used, when the developer visiting the page has some apps.
There was a problem hiding this comment.
ah, you're right. I misread if not addons but that makes sense. This must be the sort by alpha or created thing.
There was a problem hiding this comment.
yeah - I almost refactored this to also be able to completely remove BaseFilter, but the PR was already enormous.
|
r+wc and passing mkt/ tests. Nice to see the rest of these go. |
|
Tests are now passing, minus the 3 that are already a problem in marketplace atm : https://ci-addons.allizom.org/job/marketplace-build-branch/77/#showFailuresLink |
Remove leftover AMO views, templates, template tags (bug 973140)
https://bugzilla.mozilla.org/show_bug.cgi?id=973140