This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Do not force portrait orientation (bug 844186) #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not quite sure why we have a django view serving our manifest when we could simply serve the fireplace file, but r+ |
|
I have no idea. I'll try to test to see if we actually use it. |
dethe
added a commit
that referenced
this pull request
Jul 22, 2014
Do not force portrait orientation (bug 844186)
|
because Fireplace is still served from Zamboni. and it's useful for generating etags, etc. I filed a bug about using Fireplace to serve content. |
|
In the meantime, maybe it would be nice to have zamboni parse & serve what fireplace provides, to keep things DRY... |
that could be slow, and there's some server-side logic right now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zamboni part of unlocking portrait orientation (so orientation can match device).