This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Tarako review queue through AdditionReview (bug 1047183) #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -277,6 +278,49 @@ function initRegionalQueue() { | |||
| })); | |||
| } | |||
|
|
|||
|
|
|||
| function initAdditionalReviewQueue() { | |||
There was a problem hiding this comment.
Small doctstringy comment on what handlers this function sets up.
|
looks good. r+wc unless you have others in mind you want to review this too |
|
Thanks for the review! |
mstriemer
added a commit
that referenced
this pull request
Aug 12, 2014
Tarako review queue through AdditionReview (bug 1047183)
| @@ -115,6 +115,11 @@ def queue_tabnav(context): | |||
| args=[mkt.regions.CN.slug]) | |||
| rv.append((url_, 'region', | |||
| _('China ({0})').format(counts['region_cn']))) | |||
| if acl.action_allowed(request, 'Apps', 'ReviewTarako'): | |||
There was a problem hiding this comment.
This won't work until we add a migration for this rule to the groups table. I don't see one currently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1047183
This adds an
AdditionalReviewmodel with its own queue to handle a Tarako review queue. The China queue is sharing the view logic and this could eventually supersede the China queue and the rereview queue but that's a task for another day.