This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
bug 1042820 - moor tidy of apps/amo #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -170,3 +170,41 @@ def escalate_prerelease_permissions(app, validation, version): | |||
| app, version, nobody, 'App uses prerelease permissions', | |||
| 'developers/emails/prerelease_escalation.ltxt', | |||
| amo.LOG.ESCALATION_PRERELEASE_APP) | |||
|
|
|||
|
|
|||
| class SeparatedValuesField(fields.Field): | |||
There was a problem hiding this comment.
I'd prefer to move this to mkt/developers/fields.py (which doesn't exist yet). Also, fix the import issue (fields is not imported)
eviljeff
force-pushed
the
moreamotidy
branch
12 times, most recently
from
0a5d7f2
to
75db70c
Compare
|
okay, this is finished for now. I could add more of course, at the risk of introducing more breakage and having a more confusing diff. |
eviljeff
force-pushed
the
moreamotidy
branch
2 times, most recently
from
249cd18
to
883009f
Compare
| if value: | ||
| self.value_list.append(base_field.clean(value)) | ||
|
|
||
| return u', '.join(self.value_list) |
There was a problem hiding this comment.
This is generally useful. I'd vote we put this in mkt/site/fields.py as it's not just a devhub thing even if that's the only place it might be used now.
|
I took a look and everything looks pretty good. Just one comment about a Field I think should be in a more general location. |
eviljeff
force-pushed
the
moreamotidy
branch
from
883009f
to
dd842cb
Compare
|
@robhudson done. |
|
r+ from me |
robhudson
added a commit
that referenced
this pull request
Sep 3, 2014
bug 1042820 - moor tidy of apps/amo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of it, by a long way, but the bits I could clearly see were used or unused. Also I figured I better push the progress so far while its still (semi-) understandable.