This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
use memcache in docker for zamboni #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andymckay
commented
Nov 27, 2014
andymckay
commented
- this lets cache machine work locally so we can see the real impact of changing queries
- needs to be used with expose memcached marketplace-env#32
| @@ -36,7 +36,7 @@ RUN npm install | |||
| ENV CLEANCSS_BIN /srv/zamboni-node/node_modules/clean-css/bin/cleancss | |||
| ENV ES_HOST elasticsearch:9200 | |||
| ENV MARKETPLACE_URL http://mp.dev | |||
| ENV MEMCACHE_URL memcache:11211 | |||
| ENV MEMCACHE_URL memcached:11211 | |||
|
Is that second commit intended to be part of this PR? |
|
yes, its all part of bug 1089848, but its hard to measure perf when docker isn't using cache machine the same way that prod does |
| # Here we use the LocMemCache backend from cache-machine, as it interprets the | ||
| # "0" timeout parameter of ``cache`` in the same way as the Memcached backend: | ||
| # as infinity. Django's LocMemCache backend interprets it as a "0 seconds" | ||
| # timeout (and thus doesn't cache at all). | ||
|
|
||
| # | ||
| # Caching is required for CSRF to work, please do not use the dummy cache. | ||
| CACHES = { |
There was a problem hiding this comment.
This should move to the else of if os.environ.get('MEMCACHE_URL'):.
|
Sounds good with the tests. r+ with the settings change. |
andymckay
pushed a commit
that referenced
this pull request
Nov 27, 2014
use memcache in docker for zamboni
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.