This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
migrate apps/amo/utils.py #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviljeff
force-pushed
the
2014-12-30
branch
2 times, most recently
from
c01a4ae
to
66d0c68
Compare
| @@ -108,10 +108,9 @@ def __call__(self, *args, **kw): | |||
| or 'django/core/files/storage.py:url' in file_fn | |||
| or 'django/core/files/storage.py:save' in file_fn | |||
| or 'django/core/files/storage.py:delete' in file_fn | |||
| or 'amo/utils.py:path' in file_fn # storage API | |||
There was a problem hiding this comment.
Is this file even used any more? I keep patching it but the comments imply it was only a temporary measure.
There was a problem hiding this comment.
Looks like you can remove it entirely.
| from mkt.site.helpers import absolutify | ||
| from mkt.site.utils import urlparams |
There was a problem hiding this comment.
Is there a reason these can't be up at the top with the rest of the imports?
There was a problem hiding this comment.
Not sure. I guess the author of lines had their reasons (at some point in the distant past). I can change and assume test failures will pick up any difficulties I suppose.
|
r+wc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
large number of changes with very little real change. Deleted unused code from utils and moved the rest (pretty much)